Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused websocket package #98

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

dmcgowan
Copy link
Member

This package serves no purpose and is not imported anywhere https://pkg.go.dev/github.com/moby/spdystream/ws. Remove this to cleanup unnecessary go.sum entries.

Signed-off-by: Derek McGowan <derek@mcg.dev>
Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aojea
Copy link

aojea commented Jun 27, 2024

LGTM

@thaJeztah
Copy link
Member

cc @adisky (if we need another maintainer review, but I'm fine with merging this after the folks above have reviewed it)

Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims merged commit 258380d into moby:master Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants